Skip to content

Drop placeholder category from focus-view commands in generated containers#316832

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/move-outline-view-to-activity-bar
Draft

Drop placeholder category from focus-view commands in generated containers#316832
Copilot wants to merge 2 commits into
mainfrom
copilot/move-outline-view-to-activity-bar

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 17, 2026

When a view is moved out of its default container (e.g. dragging Outline from the Explorer to the Activity Bar), it lands in an auto-generated ViewContainer whose title is the internal placeholder "User View Container". ViewsService was using that title as the category for the view's Focus on … View action, so the Command Palette ended up showing entries like User View Container: Focus on Outline View.

Changes:

  • viewsService.ts: when registering the focus action, pass undefined as the category if the host container is generated, so the Command Palette shows just Focus on Outline View. Behavior for views in regular containers (e.g. Explorer: Focus on Outline View) is unchanged.
  • IViewDescriptorService: expose the previously private isGeneratedContainerId(id) so callers can identify auto-generated containers without reaching into internals.
disposables.add(this.registerFocusViewAction(
    viewDescriptor,
    this.viewDescriptorService.isGeneratedContainerId(container.id) ? undefined : container.title
));

This aligns with the existing intent already noted at the placeholder definition: // having a placeholder title - this should not be shown anywhere.

Copilot AI requested review from Copilot and removed request for Copilot May 17, 2026 01:32
Copilot AI linked an issue May 17, 2026 that may be closed by this pull request
…ed containers

Co-authored-by: dmitrivMS <9581278+dmitrivMS@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot May 17, 2026 01:47
Copilot AI changed the title [WIP] Move outline view to activity bar and update command name Drop placeholder category from focus-view commands in generated containers May 17, 2026
Copilot AI requested a review from dmitrivMS May 17, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Moving outline view out of explorer makes command name weird

2 participants